Fix over-reading while de-serializing #107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lemire
reviewed
Sep 7, 2022
bitset.go
Outdated
| if _, err := reader.Read(item); err != nil { | ||
| if err == io.EOF { | ||
| break // done | ||
| return 0, io.ErrUnexpectedEOF |
There was a problem hiding this comment.
Can't we just remove this branch here?
|
Please have a look at my comment. Can this code be even simpler ? |
thanhpk
force-pushed
the
fix-over-reading
branch
from
473d6b8 to
2b11bc5
Compare
|
Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The loop in the ReadFrom method has a wrong boundary condition. It should looping through word-length instead of bit-length.
If the input file has trailing data, it would over read and crash the program. See bits-and-blooms/bloom#85.
This pull request fix the problem and add a test case to prove its correctness.